refactor(sandbox): use mpc contract interface - #3939
Draft
kevindeforth wants to merge 2 commits into
Draft
Conversation
kevindeforth
force-pushed
the
kd/sign-sandbox
branch
from
July 23, 2026 12:15
971fed3 to
9e82941
Compare
…tHandle Converts the sandbox tests hand-rolled calls whose methods exist on the handle: propose_update (deposit now computed by the interface), vote_update, vote_add_domains, vote_new_parameters, vote_cancel_keygen, vote_cancel_resharing, vote_update_foreign_chain_providers, register_foreign_chain_support, verify_tee, and verify_foreign_transaction. Async fan-outs go through execute_async_handle_calls, an AsyncSandboxCaller-backed twin of execute_async_transactions. Kept raw: deliberately malformed or under-deposited wire tests, the legacy V1 sign shape, gas-measurement votes with tight attachments, and methods without a handle equivalent (init*, respond*, vote_pk, vote_reshared, vote_code_hash, keygen/reshare instances).
kevindeforth
force-pushed
the
kd/sign-sandbox
branch
from
July 24, 2026 21:41
9e82941 to
2bbf8ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
will update this in parallel to the e2e test improvements.
part of #3693